Make digest regex less strict on .map extensions

rails · May 30, 2024 · e1b1d86 · e1b1d86
1 parent c14f2b4
commit e1b1d86
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/propshaft/server.rb b/lib/propshaft/server.rb
@@ -35,7 +35,7 @@ def inspect
   private
     def extract_path_and_digest(env)
       full_path = Rack::Utils.unescape(env["PATH_INFO"].to_s.sub(/^\//, ""))
-      digest    = full_path[/-([0-9a-zA-Z]{7,128})\.(?!digested)[^.]+\z/, 1]
+      digest    = full_path[/-([0-9a-zA-Z]{7,128})\.(?!digested)([^.]|.map)+\z/, 1]
       path      = digest ? full_path.sub("-#{digest}", "") : full_path
 
       [ path, digest ]

diff --git a/test/propshaft/server_test.rb b/test/propshaft/server_test.rb
@@ -35,6 +35,12 @@ class Propshaft::ServerTest < ActiveSupport::TestCase
     assert_equal 200, last_response.status
   end
 
+  test "serve a sourcemap" do
+    asset = @assembly.load_path.find("file-is-a-sourcemap.js.map")
+    get "/#{asset.digested_path}"
+    assert_equal 200, last_response.status
+  end
+
   test "not found" do
     get "/not-found.js"