Fix sourceMappingURL in compressed/minified files #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of right now, the
SourceMappingUrls
compiler does not work with sass compressed CSS files, as the regex ...propshaft/lib/propshaft/compiler/source_mapping_urls.rb
Line 6 in 26082d0
... used to detect sourceMappingURLS expects the comment to be in a new line (which is not the case in the compressed mode, as it outputs everything in a single line).
Following what is stated in the Source Map Proposal, that the annotation must be at the end of the source, I've updated the regex so instead of looking for the comment at the start of a line, it looks for it at the end of the source, and included tests for compressed JS and CSS files.
The new regex should cover all the possible scenarios of how source map annotations are being appended to the generated CSS/JS file:
Let me know if there is anything I need to update to get this merged.