Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release workflow using Trusted publishing #202

Closed
wants to merge 1 commit into from

Conversation

rafaelfranca
Copy link
Member

Releasing is done now by publishing a new release on GitHub.

Releasing is done now by publishing a new release on GitHub.
@dhh
Copy link
Member

dhh commented Sep 8, 2024

So flow is:

  1. Run bin/release to bump version + create tag
  2. Manually add a new release on GH
  3. This flow pushes the gem?

@rafaelfranca
Copy link
Member Author

Yes. Pretty much.

@dhh
Copy link
Member

dhh commented Sep 9, 2024

Maybe I'm not entirely following what this would buy us, then? If you still have to run bin/release, what extra do we get from having GH handle that part of the release? The gem release is still gated by RubyGems and 2FA. So security shouldn't be a consideration there?

@rafaelfranca
Copy link
Member Author

For small gems this doesn't buy us much other than we probably can decrease the number of people allowed to push gems in Rubygem.org.

And, given new people release access is as easy as only adding to GitHub. No need to also go through all the gems and adding that person with push access on RubyGems.org. This doesn't happen often, but when it does, sometimes leave us open to attacks.

I'm not sold the overhead of two steps is good enough for small gems, that is why I opened the PR. For Rails, I think it is no brainer.

@dhh
Copy link
Member

dhh commented Sep 9, 2024

Yeah, I think that's probably fair. That user management is easier on GitHub than through RubyGems, but that does seem like a fairly minor advantage in the grand scheme of things. And yes, I think the real test will be whether the GH flow allows us to encode the much more complicated multi-stage release process for Rails. Would very much like to see that encoded and clarified!

@dhh dhh closed this Sep 9, 2024
@rafaelfranca rafaelfranca deleted the rm-release-workflow branch September 9, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants