Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more a request for comment than a pull req to merge.
It adds a minitest plugin so we can do stuff like
rails test --benchmark
to run perf test in benchmark mode.It adds a minitest plugin that tries to get back the pre rails-4 feature of
rake test
not running performance tests. In all my projects perf test requires different db than test db, they also took a long time to run. So it's not practical to run them with everyrake test
.In rails-4 world i've used a workaround like this:
In rails 5 world this would be implemented by a minitest plugin. But i'm not sure who want's to run perf test together vs who doesn't. Maybe it should be a different rubygem. Like if you adding 'gem "rails-perftest-separate"' will run not run perftest on rails test run.
Otherwise i assume the rails test --benchmark can be usefull in rails-perftest.