Skip to content

Conversation

@p-schlickmann
Copy link
Contributor

@p-schlickmann p-schlickmann commented Oct 28, 2025

Hey @rosa! How you've been?

Using the CI artifact with Rails logs has been very helpful to diagnose the flakes 🎉.

This PR aims to fix 3 things:

@p-schlickmann
Copy link
Contributor Author

Whoops... Seems like I messed up concurrency_controls_test.rb#L38

Taking a look 😅.

@p-schlickmann
Copy link
Contributor Author

p-schlickmann commented Oct 29, 2025

Seems like I got it right this time @rosa! Can you double check?

I believe that test is asserting "000" will be overwritten by the NonOverlapping jobs. I just increased the time gap between each job to prevent races.

The assertion was failing like this:

--- expected 
+++ actual 
@@ -1 +1 @@ 
- "sAcAsBcBsCcCsDcDsEcEsFcFsGcGsHcHsIcIsJcJsKcK" 
+ "s000c000sAcAsBcBsCcCsDcDsEcEsGcGsHcHsIcIsJcJsKcK"

Copy link
Member

@rosa rosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @p-schlickmann!

@rosa rosa merged commit ac912dd into rails:main Oct 29, 2025
43 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants