Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop base64 gem from dependency #810

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Drop base64 gem from dependency #810

merged 1 commit into from
Oct 1, 2024

Commits on Sep 23, 2024

  1. Drop base64 gem from dependency 

    This following warning is shown in test.
```
/Users/ryunosuke.sato/src/github.com/rails/sprockets/lib/sprockets/mime.rb:2: warning: base64 was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.
You can add base64 to your Gemfile or gemspec to silence this warning.
```

Instead of adding base64 to dependency, the usage of `Base64#strict_encode64` and `Base64#encode64` have replaced with `Array#pack`.
    @tricknotes
    tricknotes committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b8eaeef View commit details
    Browse the repository at this point in the history