This repository was archived by the owner on Aug 17, 2017. It is now read-only.
Fix fetch and add unit test. #173
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior of
fetch
is incorrect if the default value passed is a hash. This occurs because of the use ofconvert_hashes_to_parameters
. If the value passed toconvert_hashes_to_parameters
is a hash, this value will be converted to aParameters
hash and stored atself[key]
. This seems inconsistent with how default values works with regular hashes.Also, looks like this file had a bunch of trailing whitespace...if you want a clean blame log I can resubmit the PR without the whitespace cleanup.