Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double negatives on bool opts with underscores #551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix double negatives on bool opts with underscores #551

wants to merge 1 commit into from

Commits on Mar 7, 2017

  1. Fix double negatives on bool opts with underscores 

    Because:

* rails#460 (released in `0.19.2`)
  introduced a change that prevents double negative options
  (`--no-no-foo`) for already negative  boolean options (`--no-foo`).
* That change checks if the option name string starts with 'no-', before
  it's `dasherized`, therefore negative options defined with underscores
  (`:no_foo`) still generate a double negative `--no-no-foo` option.

This change:

* Adds a test for, and fixes the double negative boolean options
  defined with underscores.
    @tommarshall
    tommarshall committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    ca7b2b6 View commit details
    Browse the repository at this point in the history