Compatibility with ActionView's lazy lookup #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translation keys beginning with '.' were taken as is by i18n_viz, not generating the full key.
|
thanks for the PR. I'm quite fine with a dependency on ActionView, but I would think it makes sense to add it to the gemspec in that case. Could you change your PR accordingly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translation keys beginning with '.' were taken as is by i18n_viz, not
generating the full key, making it quite useless.
This pull request introduces the use of ActionView's method "scope_key_by_partial", used in the translate method to get the full scope automatically based on the current view.
Please note that this introduces a hard dependency on ActionView. If you wish to become Rails agnostic, a different implementation testing the existence of this method is necessary.
This was tested and implemented on Rails 4. I unfortunately lack time to test it on older versions of Rails.