Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ provide affiliate logo in area #99

Merged
merged 1 commit into from
Apr 22, 2021
Merged

✨ provide affiliate logo in area #99

merged 1 commit into from
Apr 22, 2021

Conversation

m0ppers
Copy link
Contributor

@m0ppers m0ppers commented Apr 20, 2021 •
edited
Loading

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@m0ppers m0ppers requested a review from bitboxer April 20, 2021 15:48
bitboxer
bitboxer approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@bitboxer bitboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but one general question about the approach.

app/models/owner.rb Show resolved Hide resolved
@bitboxer bitboxer mentioned this pull request Apr 21, 2021
Open
@bitboxer bitboxer merged commit d6d235a into master Apr 22, 2021
@bitboxer bitboxer deleted the feature/affiliate-logo-checkin branch April 22, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salimhb salimhb salimhb left review comments

@bitboxer bitboxer bitboxer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m0ppers @CLAassistant @bitboxer @salimhb