Use list-like flags for flags that take a list of options #905
Conversation
|
Going to hold off on merging this PR for now since it requires a major version update as I am guessing the old way of specifying multiple args does not work anymore? |
|
Yeah it doesn't. I was thinking that maybe we could introduce parsing of each option to see if there should be splitting but idk if there is a shell word-splitting library in rust we can pull in. |
|
Honestly, I believe we originally had that form of list arg parsing initially and migrated it to what we have currently in this PR #679. I will discuss with the team the best option moving forward. Unfortunately, we are unlikely to make a major version update just for this change. |
|
If we did shell-parsing of the values when there is only one value, would that be enough to get this into a minor? |
|
One thing I noticed is that at least the |
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
@coffee-cup is there anything I can do to help make this change more palatable? |
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
josegonzalez
force-pushed
the
651-list-like-labels
branch
from
47e0ab1
to
504007f
Compare
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
josegonzalez
force-pushed
the
651-list-like-labels
branch
from
504007f
to
5e446e1
Compare
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
josegonzalez
force-pushed
the
651-list-like-labels
branch
from
5e446e1
to
67bfc88
Compare
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
josegonzalez
force-pushed
the
651-list-like-labels
branch
from
67bfc88
to
0c88000
Compare
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
This changes the parser from:
--label one two three
to using the following format:
--label one --label two --label three
This follows how the docker daemon exposes the flags.
Refs railwayapp#651
josegonzalez
force-pushed
the
651-list-like-labels
branch
from
0c88000
to
9029385
Compare
|
Is there any interest in this PR at all? If not, I can just close the PR. |
|
Closing as there hasn't been any interest from upstream in reviewing/merging the PR. |
|
Hi @josegonzalez, |
|
Just updating, Not sure what happened but seems like list-like flags (for labels at least) suddenly work in main (the latest nixpacks cli does locally anyways)! Maybe someone jingled some keys :) |
This PR migrates the existing flags that use a list of values for a single flag (
--flag value1 value2) to a more common format of list of flags (--flag value1 --flag value2). This allows folks to more seamlessly switch from other CLI tools likedockerorpack.