Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chain Badge consolidation & backend delivery #6328

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Chain Badge consolidation & backend delivery #6328

wants to merge 21 commits into from

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Dec 12, 2024 •
edited
Loading

WHEN REVIEWING FILES, MAKE SURE YOU FILTER OUR .png / .json FILES

Blocked until #6344 lands as we currently rely on local ios imagesets for chain selectors.

What changed (plus any additional context for devs)

  • Consumed badgeURL from backendNetworks instead of relying on local assets
  • Consolidated RainbowCoinIcon and SwapCoinIcon into the same component
  • Consolidated all the chain badge components to use the same component (with the exception of AnimatedChainImage which relies on a SharedValue)
  • Decoupled swaps from AnimatedChainImage
    • Any additional styling for that specific instance was moved out to wrap the component instead of being built in
  • Removed EthCoinIcon and instead now rely on RainbowCoinIcon with ETH mainnet information
  • Converts chain selector dropdowns to remote images as well

Screen recordings / screenshots

// wip

What to test

TestFlight: 1.9.50 (3)
https://www.notion.so/rainbowdotme/App-Chain-Image-QA-Checklist-15fb001b85b480839cb1e0cf1665de12

@brunobar79 brunobar79 added the release for release blockers and release candidate branches label Dec 12, 2024
@walmat walmat removed the release for release blockers and release candidate branches label Dec 13, 2024
@walmat walmat marked this pull request as ready for review December 17, 2024 18:42
@brunobar79
Copy link
Member

Launch in simulator or device for 31c82d1

@walmat walmat added the blocked Blocked by anything (design, UI work, other task, etc) label Dec 17, 2024
@brunobar79
Copy link
Member

Launch in simulator or device for 5f8f028

@brunobar79
Copy link
Member

Launch in simulator or device for a282bd6

ibrahimtaveras00
ibrahimtaveras00 requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://linear.app/rainbow/issue/APP-2216/chain-badge-consolidation-and-backend-delivery-6328-qa-bug-epic

@walmat
Convert Chain Selection DropdownMenu to Backend Networks (#6344)
e093c7a 
* start work on converting existing chain selection dropdowns to Zeego

* available networks v2 convert

* add token icons to claim dropdown and fix but with AvailableNetworks not showing ever

* latest changes to try to get hitslop to work
@brunobar79
Copy link
Member

Launch in simulator or device for c3048bc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 requested changes

@derHowie derHowie Awaiting requested review from derHowie

@benisgold benisgold Awaiting requested review from benisgold

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
blocked Blocked by anything (design, UI work, other task, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walmat @brunobar79 @ibrahimtaveras00