Reintroduce support for crosschain search results in swaps search #6440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinchung
commented
Feb 3, 2025
| @@ -4,6 +4,27 @@ import { SearchAsset } from '@/__swaps__/types/search'; | |||
| import { Address } from 'viem'; | |||
| import { isNativeAsset } from '@/handlers/assets'; | |||
|
|
|||
| export function parseTokenSearchResults(assets: SearchAsset[]): SearchAsset[] { | |||
There was a problem hiding this comment.
added a new function here that will eventually replace / consolidate the other parsers in this file once I finish moving DiscoverSearch over to the new query store.
jinchung
commented
Feb 3, 2025
| @@ -77,29 +72,6 @@ export const useTokenSearchStore = createQueryStore<VerifiedTokenData, TokenSear | |||
| { persistThrottleMs: time.seconds(8), storageKey: 'verifiedTokenSearch' } | |||
| ); | |||
|
|
|||
| export const useUnverifiedTokenSearchStore = createQueryStore<SearchAsset[], TokenSearchParams<TokenLists.HighLiquidity>>( | |||
There was a problem hiding this comment.
this is the removal of the "extra" call for assets on the unverified list - these results will now show up as part of the main call to tokenSearchQueryFunction
jinchung
changed the title
christianbaroni
approved these changes
Feb 6, 2025
jinchung
merged commit 5651f36
into
@christian/query-store-token-search
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-2321
What changed (plus any additional context for devs)
Screen recordings / screenshots
Example showing crosschain results:
Another example showing crosschain results:
Example showing result for address search:
What to test