fix: allow spaces in firmware names (zwave-js#1702)

package.json

@@ -119,7 +119,8 @@
     "config": "ts-node maintenance/importConfig.ts",
     "docs": "docsify serve docs",
     "docs:generate": "ts-node -P maintenance/tsconfig.json maintenance/generateTypedDocs.ts",
-    "perf": "ts-node test/valuedb-perf.ts"
+    "test:perf": "ts-node test/valuedb-perf.ts",
+    "test:firmware": "ts-node test/firmware-extraction.ts"
   },
   "readme": "README.md",
   "husky": {

packages/core/src/util/firmware.ts

@@ -163,7 +163,7 @@ function extractFirmwareAeotec(data: Buffer): Firmware {
 			firmwareNameBytes.indexOf(0, firmwareNameOffset),
 		)
 		.toString("utf8");
-	if (!/^[a-zA-Z0-9_]+$/.test(firmwareName)) {
+	if (!/^[a-zA-Z0-9_ -]+$/.test(firmwareName)) {
 		throw new ZWaveError(
 			"This does not appear to be a valid Aeotec updater (invalid firmware name)!",
 			ZWaveErrorCodes.Argument_Invalid,

test/firmware-extraction.ts

@@ -0,0 +1,9 @@
+import { extractFirmware, guessFirmwareFileFormat } from "@zwave-js/core";
+import * as fs from "fs-extra";
+
+void (async () => {
+	const filename = process.argv[2];
+	const data = await fs.readFile(filename);
+	const format = guessFirmwareFileFormat(filename, data);
+	extractFirmware(data, format);
+})();