Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid appearance of emoji's used for Dark-mode and Normal-mode for different browsers. #11

Open
Neilblaze opened this issue Dec 21, 2019 · 7 comments
Labels
good first issue Good for newcomers

Comments

@Neilblaze
Copy link
Contributor

Neilblaze commented Dec 21, 2019

What I observed that the icons/emoji's which is being used in the landing page i.e. for both 'popular/battle' section in https://github-battlereact.netlify.com/ for enabling Dark mode from Normal mode and vice versa (and one more) is not a supported Unicode version of the emoji and thus the icons are becoming invalid in appearance. I have tested this link on three different browsers on my windows 10 OS, which are Chrome (version 79.0.3945.88), Mozilla Firefox (version 70.0.1), & the latest version of Brave browser, & it seems that the emoji(s) are supported by the Mozilla Firefox browser, but not the rest.

So I am attaching some pictures that I have taken from different browsers. And also I would like to fix this issue.
BRAVE1
BRAVE2
CHROME
CHROME1
FIREFOX1
FIREFOX2

@rajat2502
Copy link
Owner

So there is a problem with just one emoji or many?

@Neilblaze
Copy link
Contributor Author

2 emoji's which are used for the Dark-Normal mode and the footer message

@dsaharia
Copy link

Any luck with the issue?

@rajat2502
Copy link
Owner

@Neilblaze Would you like tom work on it?

@rajat2502 rajat2502 added the good first issue Good for newcomers label Dec 25, 2019
@Neilblaze
Copy link
Contributor Author

@rajat2502 Yeah sure :)

@rajat2502
Copy link
Owner

Are you working on it or should I assign it to someone else?

@Neilblaze
Copy link
Contributor Author

I am having some internet issues from the past few days. So I am unable to work on this right now. For the while you can assign anyone instead of me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants