add more template functions according to fermyon/bartholomew#26 fermy…

[karthik2804]

Added more helpers as per fermyon/bartholomew#26, fermyon/bartholomew#27, fermyon/bartholomew#28 & fermyon/bartholomew#31

Signed-off-by: karthik Ganeshram [email protected]

[rajatjindal]

thanks a lot for the PR, the changes look great. I just have a few minor comments.

[rajatjindal]

should this be '\n' instead of '/n'?

[rajatjindal]

could you please write some unit tests for this function. i tried running this through template and got following error:

thread 'main' panicked at 'attempt to subtract with overflow', src/template.rs:52:20

examples/template.rs

use handlebars::Handlebars;
use handlebars_sprig;

fn main() {
    // Get a handlebars instance
    let mut hbs = Handlebars::new();

    // THE IMPORTANT PART: Add the helpers
    handlebars_sprig::template::addhelpers(&mut hbs);

    // From this point, you can do whatever you want to do with the
    // handlebars instance. It will have all of the functions available
    // to the templates.
    let tpl = "{{ wrap 5 \"this is a string that needs wrapping\" }}";

    // Example of running a template render.
    let empty_context: Vec<String> = vec![];
    println!(
        "Template produced: {}",
        hbs.render_template(tpl, &empty_context).unwrap()
    )
}

[rajatjindal]

also, please test using unicode characters and verify how the function behaves.

[rajatjindal]

i find the code more readable when there are not too many nested if conditions. you can probably write this as:

if wraploc > index {
    i += 1
    continue
}

for k in (0..i).rev() 
.
.
.

[karthik2804]

@rajatjindal text wrapping seems to require a bit more logic and testing than what has been presented so far. What would your thoughts be on the deffering adding wrap to a later PR (potentially just pulling in a library)?

[rajatjindal]

sounds good to me. we can add that in a later PR

[karthik2804]

This is ready for a rereview

[rajatjindal]

thanks a lot for your PR.

[karthik2804]

Would you like to PR the changes into Bartholomew or should I go ahead and make the PR?

[rajatjindal]

if you could pls do it, that would be great.

[karthik2804]

Will do it today!