Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Prerequisites in README.md #77

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Update Prerequisites in README.md #77

merged 2 commits into from
Apr 7, 2020

Conversation

maheshschand
Copy link
Contributor

No description provided.

@maheshschand
Copy link
Contributor Author

This resolves a task in issue #40 . @sagar-sehgal Can you please review this?

@thesagarsehgal
Copy link
Collaborator

Seems to be great. @rajatkb you can have a look and then merge.

rajatkb
rajatkb requested changes Apr 6, 2020
View reviewed changes
Copy link
Owner

@rajatkb rajatkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Users may also require to install Elastic Search on their system. So maybe we should add that also, otherwise it looks great.

@maheshschand
Copy link
Contributor Author

maheshschand commented Apr 6, 2020 via email

@rajatkb rajatkb added beginner GSSOC label for beginner tag documentation Improvements or additions to documentation gssoc20 GSSOC label for gscco20 tag labels Apr 7, 2020
@maheshschand
Copy link
Contributor Author

@rajatkb I made necessary changes. Can you review it?

rajatkb
rajatkb approved these changes Apr 7, 2020
View reviewed changes
Copy link
Owner

@rajatkb rajatkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All Ok

@maheshschand
Copy link
Contributor Author

Can you merge this pull request too? @rajatkb @sagar-sehgal

@rajatkb rajatkb merged commit 3b89b86 into rajatkb:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajatkb rajatkb rajatkb approved these changes

@thesagarsehgal thesagarsehgal thesagarsehgal approved these changes

Assignees

@maheshschand maheshschand

Labels
beginner GSSOC label for beginner tag documentation Improvements or additions to documentation gssoc20 GSSOC label for gscco20 tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maheshschand @thesagarsehgal @rajatkb