-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Prerequisites in README.md #77
Conversation
This resolves a task in issue #40 . @sagar-sehgal Can you please review this? |
Seems to be great. @rajatkb you can have a look and then merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Users may also require to install Elastic Search on their system. So maybe we should add that also, otherwise it looks great.
Sure.
…On Mon, Apr 6, 2020, 09:40 Rajat Kanti Bhattacharjee < ***@***.***> wrote:
***@***.**** requested changes on this pull request.
- Users may also require to install Elastic Search on their system. So
maybe we should add that also, otherwise it looks great.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#77 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANNB7COYKAY4YW3Y5HLRNZDRLFIZRANCNFSM4LYJMXJA>
.
|
@rajatkb I made necessary changes. Can you review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All Ok
Can you merge this pull request too? @rajatkb @sagar-sehgal |
No description provided.