Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Add conferences list and View Conference Page #90

Merged

Conversation

Kajol-Kumari
Copy link
Contributor

@Kajol-Kumari Kajol-Kumari commented Apr 14, 2020

#85 [Feat.] Add list of events (all events) layout page
#86 [Feat.] Individual event details page layout

Required functionalities added:

  • Add conferences to the page based on scroll event
  • Clicking on the conference will view the particular conference.

@Kajol-Kumari
Copy link
Contributor Author

Kajol-Kumari commented Apr 14, 2020

ezgif com-video-to-gif
@rajatkb @anoopsingh1996 while fetching the conferences based on scroll event by the user, though the fetching is happening correctly but the html page is not getting updated accordingly. How can i achieve this?

@rajatkb
Copy link
Owner

rajatkb commented Apr 14, 2020

create an array variable, in html iterate over the array elements to create the template.
.
Populate i.e appand the new data in this array every time. U can also look into fireship tutorial for same. Asyn pipes can help also for this. https://youtu.be/Cy5MjeXZobE , this one is in firebase but principal would remain same.

@anoop-singh-dev
Copy link
Collaborator

@amandhamija98
Copy link
Contributor

Hi, may I do the virtual scroll part

@Kajol-Kumari
Copy link
Contributor Author

Kajol-Kumari commented Apr 14, 2020

Hey @amandhamija98 please complete the assigned issue first as it is required by me for the functionality. Also i will be done with the functionality part maybe by tonight. Then u can work on the UI part after tackling the assigned issues.

Also @anoopsingh1996 If i am not wrong, virtual scroll will require the data to be fetched in hand and then display it according to the itemSize specified which will not satisfy our requirement. So i have done it through the approach siggested by @rajatkb and it's working fine that way.

@amandhamija98
Copy link
Contributor

Sure, I am almost done, will be submitting a PR soon

@rajatkb
Copy link
Owner

rajatkb commented Apr 14, 2020

Make a draft PR Kajol for the problem u mentioned and the solution code so that we can review and suggest improvement if required.

@Kajol-Kumari
Copy link
Contributor Author

@rajatkb @anoopsingh1996 current status of the functionality:

ezgif com-video-to-gif (1)

@Kajol-Kumari Kajol-Kumari marked this pull request as ready for review April 14, 2020 16:36
@rajatkb
Copy link
Owner

rajatkb commented Apr 18, 2020

@rajatkb @anoopsingh1996 current status of the functionality:

ezgif com-video-to-gif (1)

Looks fine functionally. Will have to work out the UI. I think @amandhamija98 's getOne request is needed as of now right ? Will update rest in code comment.

@Kajol-Kumari
Copy link
Contributor Author

@rajatkb I have resolved the conflicts. Can u please merge it now.

@rajatkb rajatkb added medium GSSOC label for beginner tag gssoc20 GSSOC label for gscco20 tag labels May 29, 2020
@rajatkb rajatkb merged commit a483dc7 into rajatkb:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc20 GSSOC label for gscco20 tag medium GSSOC label for beginner tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants