Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Present is no longer ignoring other rules when field is empty #109

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Present is no longer ignoring other rules when field is empty #109

merged 1 commit into from
Jul 23, 2020

Conversation

ThHareau
Copy link
Contributor

@ThHareau ThHareau commented Jan 7, 2020

Fix for #108

ThHareau
ThHareau commented Jan 7, 2020
View reviewed changes
src/Rules/Present.php
*
* @return void
*/
protected function setAttributeAsRequired()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate of Required::setAttributeAsRequired. If you want, I can extract the method in a trait, and reuse it in both classes

@BafS
Copy link

BafS commented Feb 21, 2020

Any new @emsifa ?

@emsifa emsifa merged commit 7a5e0e5 into rakit:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThHareau @BafS @emsifa