Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: update sample app UI (SDKCF-6856) #74

Merged
merged 1 commit into from
Feb 7, 2024
Merged

improve: update sample app UI (SDKCF-6856) #74

merged 1 commit into from
Feb 7, 2024

Conversation

Esakkiraja-Pothikannan
Copy link
Contributor

Description:

  • Updated SampleApp UI by showing total number of event count in EventList page
  • Sorted the list using by firstOccurrance value and sorted dictionary

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rakutentech-danger-bot
Copy link
Collaborator

Current coverage for RSDKUtils.framework is 83.72%

✅ No files affecting coverage found

Powered by xcov

Generated by 🚫 Danger

@mdusmangani-jp mdusmangani-jp self-requested a review February 6, 2024 07:52
mdusmangani-jp
mdusmangani-jp approved these changes Feb 6, 2024
View reviewed changes
Copy link

@mdusmangani-jp mdusmangani-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Esakkiraja-Pothikannan Esakkiraja-Pothikannan merged commit c771a68 into rakutentech:feat/event-logger Feb 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdusmangani-jp mdusmangani-jp mdusmangani-jp approved these changes

@SoumenRautray SoumenRautray Awaiting requested review from SoumenRautray

@anish-munirathinam anish-munirathinam Awaiting requested review from anish-munirathinam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Esakkiraja-Pothikannan @rakutentech-danger-bot @mdusmangani-jp