Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MALI-1434] [JS Sample App]Contacts getting fetched even when permission is denied #292

Conversation

GondiTilak
Copy link
Contributor

Description

Fixed issue in sample app when fetching contacts with permissions turned off.

Links

MALI-1434

Checklist

…ion is denied

Fixed issue in sample app when fetching contacts with permissions turned off.
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1800a3) 75.02% compared to head (163a42f) 75.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   75.02%   75.02%           
=======================================
  Files          29       29           
  Lines         877      877           
  Branches       66       66           
=======================================
  Hits          658      658           
  Misses        194      194           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GondiTilak GondiTilak enabled auto-merge (squash) February 14, 2024 08:17
@rleojoseph rleojoseph disabled auto-merge February 14, 2024 08:21
@rleojoseph rleojoseph merged commit 1cf26ef into rakutentech:master Feb 14, 2024
7 checks passed
Copy link
Contributor

@munir-rakuten munir-rakuten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants