Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for aarch64 #10

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Fix build for aarch64 #10

merged 1 commit into from
Jun 22, 2024

Conversation

seijikun
Copy link
Contributor

I tried using ffsvm on aarch64, but after fixing simd_aligned, the build fails in ffsvm.
That's because in comparison to is_x86_feature_detected, the is_aarch64_feature_detected macro is in the std::arch namespace instead of std (?!).
This fixes the build for me.

@ralfbiedert
Copy link
Owner

Thanks!

@ralfbiedert ralfbiedert merged commit ca9701d into ralfbiedert:master Jun 22, 2024
1 check passed
@ralfbiedert
Copy link
Owner

I fixed the x86 warning caused by the unused std::arch, please let me know if broke aarch64 again, as I don't have the toolchain set up right now.

@seijikun
Copy link
Contributor Author

ffsvm-0.9.2 builds on aarch64 now, thank you!
However, the change in ralfbiedert/simd_aligned#2 is also required for it to work.

@ralfbiedert
Copy link
Owner

Ah sorry, missed that PR. Should be published now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants