feat: port search for async #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singulared
requested changes
Sep 11, 2018
There was a problem hiding this comment.
Hello @jagguli!
Thanks for your PR but i have some questions:
Can you add some tests for search methods and please check my comment in _request method
| self._writer.write(self._encode_message(msg_code, msg)) | ||
| if not isinstance(msg, Msg): | ||
| msg = self._encode_message(msg_code, msg) | ||
| self._writer.write(msg) |
There was a problem hiding this comment.
I think we can't pass Msg instance directly into https://docs.python.org/3/library/asyncio-protocol.html#asyncio.WriteTransport.write.
We need to add some transformation method Msg() -> bytes
There was a problem hiding this comment.
Maby we can use something like:
self._encode_message(*msg[:2])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.