Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken code that never returned the current of the LEDs in AMPs #12

Merged
merged 4 commits into from
Feb 23, 2022

Conversation

zhengmaxwell
Copy link
Contributor

moved find_max_brightness to python-owl in order to be compatible with analog settings
https://gitlab.com/ramonaoptics/mcam/python-owl/-/issues/783

@hmaarrfk
Copy link
Member

hmaarrfk commented Feb 9, 2022

Tests are failing due to the removal of the find max brightness in the API. Please leave that in.

You can override it in our subclass.

Finally, you can remove the analog one. It was broken anyway

@zhengmaxwell
Copy link
Contributor Author

Ok I'll leave those two functions in. We can close this PR then.
When you say "remove the analog one", do you mean the previous PR: #8

@hmaarrfk
Copy link
Member

Please see new PR. Generally speaking, you cannot simply remove functions from a public API.

People do start to rely on them.

You can however remove broken code that was never working.

For things that are specific to our hardware, we can always overwrite the properties.

@hmaarrfk hmaarrfk changed the title move functions to python_owl Remove broken code that never returned the current of the LEDs in AMPs Feb 14, 2022
@hmaarrfk hmaarrfk merged commit 9320579 into ramonaoptics:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants