-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature proposal for ticker.calendar #1726
base: dev
Are you sure you want to change the base?
Conversation
78dbe86
to
d16a589
Compare
@@ -559,7 +563,7 @@ def __init__(self, data: TickerData, proxy=None): | |||
self._retired_info = None | |||
self._sustainability = None | |||
self._recommendations = None | |||
self._calendar = None | |||
self._calendar = CalendarData(data.ticker) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass through data
object, use that for web requests.
I'm basically black-box-testing your calendar and struggling. Look below, one is easier than the other.
?
nice Maybe write some documentation? Or something like this: yfinance/yfinance/scrapers/quote.py Line 173 in 308e58b
|
@ValueRaider Is |
Essentially yes but subtle difference.
|
FYI |
This is a clearner implementation regarding #1712