Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruff linter checks #1756

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Add Ruff linter checks #1756

merged 2 commits into from
Dec 9, 2023

Conversation

marco-carvalho
Copy link
Contributor

Overview

This PR introduces the integration of Ruff, a fast and efficient Python linter, into the yfinance project. The goal is to improve and maintain the code quality by enforcing style and coding standards.

Benefits

  • Speed: Ruff's performance-oriented design allows for quick linting, making it an ideal tool for continuous integration environments.
  • Readability and Maintenance: Enforcing a consistent coding style enhances code readability and maintainability.
  • Error Prevention: Early detection of potential errors and code smells helps in maintaining the overall quality of the codebase.

Changes

  • Applied Ruff checks to the existing codebase and made necessary adjustments to ensure compliance with the linter's rules.
  • Created a new GitHub Action ruff.yml that triggers on pull requests to the master and main branches.

@ValueRaider
Copy link
Collaborator

ValueRaider commented Dec 2, 2023

This is much needed, thanks. But can you target dev branch instead? #1084 Just in case this broke something.

Probably good idea to trigger action on dev too.

@marco-carvalho marco-carvalho changed the base branch from main to dev December 3, 2023 01:12
@ValueRaider
Copy link
Collaborator

ValueRaider commented Dec 3, 2023

... and rebase to dev.

@ValueRaider
Copy link
Collaborator

@marco-carvalho I've rebased. Looks good to me, agree?

Copy link
Collaborator

@ValueRaider ValueRaider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question

tests/prices.py Show resolved Hide resolved
@ValueRaider ValueRaider marked this pull request as ready for review December 9, 2023 21:32
@ValueRaider ValueRaider merged commit fce4707 into ranaroussi:dev Dec 9, 2023
1 check passed
@ValueRaider ValueRaider mentioned this pull request Jan 6, 2024
@ValueRaider ValueRaider changed the title Add Ruff Add Ruff linter checks Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants