-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Insider Roster & Transactions #1772
Conversation
I see opportunities to improve formatting. Data types, index, etc. See |
I love this PR, I'm excited just with the idea of see this one included in 0.2.34 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change it to get data from API, not from page?
Change scraping from page to parse json data from quote summary request. Modules are "institutionOwnership", "fundOwnership", "majorDirectHolders", "majorHoldersBreakdown", "insiderTransactions", "insiderHolders", "netSharePurchaseActivity"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job. I think we can merge it.
Sounds good! Could you approve the PR and merge @bot-unit? I don't have access. Or maybe @ValueRaider can you take a look? |
I don't have access. And wait. I have some changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So. It's good and working. Just correct pd.Dataframe creation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So. @ValueRaider
Thanks to @JuliaLWang8 We did it.
We have good code for take data from API, we have commented out code if API will blocked.
OMG! |
I spotted the
|
Removed in last commit @ValueRaider |
Code looks fine. Add this to README:
Then squash the commits. |
9ee9280
to
dc957ee
Compare
Done both! |
@ValueRaider @JuliaLWang8 @bot-unit is there a way to pip install |
No, have to manually reinstall. Subscribe for notifications. |
Thanks @ValueRaider |
Added implementations for all data displayed on the holders page.
Can access dataframes:
Also added an additional column called 'Position' separating people's names and titles since they are grouped together on the endpoint. This is because Yahoo displays insider names with their titles/positions below their name.