-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync dev -> main #1927
Merged
Merged
sync dev -> main #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix potential for price repair to discard price=0 rows
Replace dead 'appdirs' package with 'platformdirs'
Drop official support for 'pandas_datareader', tag pdr_override() as deprecated. Also removed deprecated argument 'download(show_errors)'.
Deprecate 'pandas_datareader', remove a deprecated argument
Fix help(yf.download) not showing the information about the function
sync main -> dev
Don't price-repair FX volume=0, is normal
Python 3.12 deprecates datetime.datetime.utcnow(). Instead of switching to datetime.datetime.now(datetime.UTC), which won't work in Python 3.11, just switch to Pandas.utcnow().
- renamed test files conform with standards - replaced utcfromtimestamp
Session switch logic was not recalculating 'self._session_is_caching'. Also removed message 'help stress-test cookie & crumb & requests_cache', clearly works now.
Add more specific error thowring base on PR 1918
Fix switching session from/to requests_cache
Original logic for repairing missing split adjustment only checked latest split. Improved logic checks ALL splits in data, because any can be missing. Then related changes to 'sudden change detection': - use prices median not mean, reduce sensitivity to noise. - handle Kuwait Dinar, which sub-divides into 1000x not 100x.
…-bad-splits Price repair: improve 'sudden change' repair for splits & currency
sync main -> dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Price repair:
Information:
Maintenance: