Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: price auto adjust confusion #1984

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ValueRaider
Copy link
Collaborator

@ValueRaider ValueRaider commented Jul 14, 2024

Fix user confusion from not knowing auto_adjust by telling them to set it. Might resolve #1982 and similar older issues.

@ValueRaider ValueRaider force-pushed the fix/price-auto-adjust-confusion branch from 776e378 to 09c864f Compare July 14, 2024 11:19
@ValueRaider ValueRaider marked this pull request as draft July 16, 2024 16:39
@JanMkl
Copy link

JanMkl commented Mar 3, 2025

This would be one way to clear the confusion like on issue #2332, #2302 and #2283.

The change seems quite polite and won't make the yfinance too noisy. If more attention is wanted then one could add short sleep after the print like:

        if not _warned_auto_adjust:
            warnings.warn("You have not set argument 'auto_adjust'. This defaults to False, but you should be setting it (Yahoo sets to True).", UserWarning)
            _warned_auto_adjust = True
            time.sleep(3)  # Pause execution for 3 seconds

@ValueRaider
Copy link
Collaborator Author

yf already prints something like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants