Fix reading timezone from earning dates #2010
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But it already has a timezone. How did you determine it was missing? |
|
I improved the test for the bug fix. Without the bugfix: |
ValueRaider
requested changes
Aug 7, 2024
…eral symbol timezone when decoding fails
mreiche
force-pushed
the
bugfix/earnings-tz
branch
from
6f76b37 to
3e35ae7
Compare
ValueRaider
approved these changes
Aug 18, 2024
ValueRaider
force-pushed
the
bugfix/earnings-tz
branch
from
0eda8ce to
9a37c7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading earning dates returns index timestamps without timezone. That's been fixed.