Skip to content

Commit

Permalink
We can now run locked-field e2e tests on Windows
Browse files Browse the repository at this point in the history
Also there's no reason for this test to mess with the context.
The only other test that does it is the separate snapshots e2e test.

Signed-off-by: Eric Promislow <[email protected]>
  • Loading branch information
ericpromislow committed Sep 11, 2023
1 parent b84729a commit 18e8390
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions e2e/lockedFields.e2e.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,10 @@ import { readDeploymentProfiles } from '@pkg/main/deploymentProfiles';
import { spawnFile } from '@pkg/utils/childProcess';
import { reopenLogs } from '@pkg/utils/logging';

import type { ElectronApplication, BrowserContext, Page } from '@playwright/test';
import type { ElectronApplication, Page } from '@playwright/test';

test.describe('Locked fields', () => {
test.skip(process.platform === 'win32', 'TODO: Implement testing on Windows');
let electronApp: ElectronApplication;
let context: BrowserContext;
let page: Page;
const appPath = path.join(__dirname, '../');
let deploymentProfile: DeploymentProfileType|null = null;
Expand Down Expand Up @@ -91,12 +89,6 @@ test.describe('Locked fields', () => {
{ containerEngine: { allowedImages: { enabled: true, patterns: ['c', 'd', 'f'] } }, kubernetes: { version: lockedK8sVersion } },
);
electronApp = await startRancherDesktop(__filename);
context = electronApp.context();

await context.tracing.start({
screenshots: true,
snapshots: true,
});
page = await electronApp.firstWindow();
});

Expand Down

0 comments on commit 18e8390

Please sign in to comment.