Skip to content

Commit

Permalink
Merge pull request #3991 from rancher-sandbox/troubleshoot-nerdctl-in…
Browse files Browse the repository at this point in the history
…fo-problems

Drop the rdctl test that switches container engines: this is flakey in e2e, done in bats, and not so flakey there.
  • Loading branch information
mook-as authored Sep 12, 2023
2 parents 277c5c8 + 15cff4d commit 82a9885
Showing 1 changed file with 1 addition and 32 deletions.
33 changes: 1 addition & 32 deletions e2e/rdctl.e2e.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import yaml from 'yaml';

import { NavPage } from './pages/nav-page';
import {
createDefaultSettings, getAlternateSetting, kubectl, retry, startRancherDesktop, teardown, tool, waitForRestartVM,
createDefaultSettings, getAlternateSetting, kubectl, retry, startRancherDesktop, teardown, waitForRestartVM,
} from './utils/TestUtils';

import {
Expand Down Expand Up @@ -1415,37 +1415,6 @@ test.describe('Command server', () => {
}
});
});
test('should verify nerdctl can talk to containerd', async() => {
const { stdout } = await rdctl(['list-settings']);
const settings: Settings = JSON.parse(stdout);

if (settings.containerEngine.name !== ContainerEngine.CONTAINERD) {
const payloadObject: RecursivePartial<Settings> = {
version: CURRENT_SETTINGS_VERSION,
containerEngine: { name: ContainerEngine.CONTAINERD },
};
const navPage = new NavPage(page);

await tool('rdctl', 'api', '/v1/settings', '--method', 'PUT', '--body', JSON.stringify(payloadObject));
await waitForRestartVM(page.locator('.progress'));
await navPage.progressBecomesReady();
}
const output = await retry(() => tool('nerdctl', 'info'));

expect(output).toMatch(/Server Version:\s+v?[.0-9]+/);
});
test('should verify docker can talk to dockerd', async() => {
const navPage = new NavPage(page);

await tool('rdctl', 'set', '--container-engine', 'moby');
await expect(navPage.progressBar).not.toBeHidden();
await waitForRestartVM(navPage.progressBar);
await navPage.progressBecomesReady();
await expect(navPage.progressBar).toBeHidden();
const output = await retry(() => tool('docker', 'info'), { delay: 500, tries: 60 });

expect(output).toMatch(/Server Version:\s+v?[.0-9]+/);
});
});

// Where is the test that pushes a supported update, you may be wondering?
Expand Down

0 comments on commit 82a9885

Please sign in to comment.