shutdown/factory-reset: ignore missing lima-home dir error. #5105
Conversation
|
This should probably go into a separate PR, but I noticed that Maybe also audit if there is other now redundant path logic in other places. |
ericpromislow
force-pushed
the
4600-force-shutdown-when-lima-missing
branch
from
1a968de
to
f731ab6
Compare
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Why do these errors abort the shutdown sequence? Should they also just be logged, and processing continues?
There was a problem hiding this comment.
Good point; processing should continue.
| default: | ||
| return fmt.Errorf("internal error: unknown shutdown initiating command of '%s'", initiatingCommand) | ||
| } | ||
| err = s.waitForAppToDieOrKillIt(checkProcessQemu, pkillQemu, 15, 2, "qemu") |
There was a problem hiding this comment.
Why is the Qemu shutdown inside the Lima conditional? It does not rely on LIMA_HOME or limactl as far as I can tell.
There was a problem hiding this comment.
I assumed it was part of lima, but moving it out is fine.
There was a problem hiding this comment.
It is, but you don't need LIMA_HOME or limactl to kill it, so you can still try...
Don't check or kill lima and qemu processes when the path to the lima directory can't be found. Signed-off-by: Eric Promislow <[email protected]>
ericpromislow
force-pushed
the
4600-force-shutdown-when-lima-missing
branch
from
f731ab6
to
26ed6dd
Compare
Fixes #4600