Make getPaths more robust

[adamkpickering]

Follow-up to #4160.

[ericpromislow]

This still doesn't make a lot of sense, because the error gets caught 3 lines later and the payload is dropped.

I think you can do what I suggested previously. Just delete the three lines

    if (result.status !== 0) {
      throw new Error(`rdctl paths failed: ${ JSON.stringify(result) }`);
    }

and set pathsData to that default for any failure.

[adamkpickering]

When spawnSync calls a command that returns a non-zero exit code, an error is not thrown. You have to check result.status (or maybe result.error?), so the if (result.status !== 0) {...} is needed. Same thing for a nonexistent command. See the following code for an example:

import child_process from 'child_process';

try {
  const result = child_process.spawnSync('cat', ['doesnotexist.txt'], {encoding: 'utf8'});
  console.log(JSON.stringify(result)); 
} catch (error) {
  console.log(`Got error ${error}`);
}

I've tried to figure out ways to simplify it with the needed if statement and a try-catch, but AFAICT this is as good as it gets. Let me know if you can see a better way 😄

[ericpromislow]

Can be simplified, but it's on the right track.

[ericpromislow]

We don't need this, going with #5127 instead