Add static hosts to TSL SANs #7379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds both static entries as Subject Alternative Names on the TLS cert. Also, define a new entry for the network gateway in /etc/hosts. Signed-off-by: Nino Kodabande <[email protected]>
mook-as
approved these changes
Aug 26, 2024
| @@ -1448,6 +1448,11 @@ export default class WSLBackend extends events.EventEmitter implements VMBackend | |||
| // Make sure the apiserver can be accessed from WSL through the internal gateway | |||
| k3sConf.ADDITIONAL_ARGS += ' --tls-san gateway.rancher-desktop.internal'; | |||
There was a problem hiding this comment.
That's not actually reachable right?
There was a problem hiding this comment.
That's not actually reachable right?
This was not answered. If the address is not reachable, why would we add it to the cert?
There was a problem hiding this comment.
Are we using gateway.rancher-desktop.internal for WSL kubeconfig then? We're using a symlink again now, so it should be back to 127.0.0.1?
There was a problem hiding this comment.
Yeah, it is back to localhost now.
There was a problem hiding this comment.
I'm still confused: Is gateway.rancher-desktop.internal used for anything? Should it still be on the cert?
Because the comment sounds wrong now:
// Make sure the apiserver can be accessed from WSL through the internal gateway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds both static entries as Subject Alternative Names on the TLS cert. Also, define a new entry for the network gateway in /etc/hosts.
Fixes: #7298