Import sudo-prompt module into our repo #7398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream repo has been archived in 2021 and no longer accepts PRs. This import is in preparation to update the bundled AppleScript applet to include aarch64 support, so it no longer requires Rosetta on M1+ machines. Signed-off-by: Jan Dubois <[email protected]>
Signed-off-by: Jan Dubois <[email protected]>
jandubois
force-pushed
the
vendor-sudo-prompt
branch
from
092e16c
to
7f6071f
Compare
jandubois
changed the title
jandubois
force-pushed
the
vendor-sudo-prompt
branch
from
7f6071f
to
9a2769f
Compare
Signed-off-by: Jan Dubois <[email protected]>
Signed-off-by: Jan Dubois <[email protected]>
jandubois
force-pushed
the
vendor-sudo-prompt
branch
2 times, most recently
from
ac510b0
to
e4e8848
Compare
|
Sorry for asking prematurely to review this PR, but I think it is now ready.
|
mook-as
requested changes
Aug 30, 2024
There was a problem hiding this comment.
Happy to see that linter fixes were in separate commits, so we have a view of what the upstream code looked like.
It would have been nice to import the upstream repo with commits (like we did for the src/go/ merge), instead of as a snapshot, but I'm not sure you feel like doing the work…
(Requesting just the jest ignore bit; everything is acceptable.)
jandubois
force-pushed
the
vendor-sudo-prompt
branch
from
e4e8848
to
b287119
Compare
Signed-off-by: Jan Dubois <[email protected]>
jandubois
force-pushed
the
vendor-sudo-prompt
branch
from
b287119
to
38ab7ba
Compare
mook-as
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream repo has been archived in 2021 and no longer accepts PRs.
This import is in preparation to update the bundled AppleScript applet to include aarch64 support (#7336), so it no longer requires Rosetta on M1+ machines.