Remove networking tunnel #7427
Merged
Remove networking tunnel #7427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nino Kodabande <[email protected]>
Signed-off-by: Nino Kodabande <[email protected]>
Signed-off-by: Nino Kodabande <[email protected]>
Signed-off-by: Nino Kodabande <[email protected]>
mook-as
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
PR looks good, but there are more things to remove:
rancher-desktop/pkg/rancher-desktop/assets/translations/en-us.yaml
Lines 331 to 333 in b03544b
- vtunnel stuff, I assume that's a separate PR.
- Same with a bunch of docs stuff.
| @@ -587,7 +584,6 @@ describe('settings', () => { | |||
| }, | |||
| experimental: { | |||
There was a problem hiding this comment.
Not for this PR, but I feel like we should update the migrater to remove empty objects…
There was a problem hiding this comment.
Yeah, I will make a follow up PR.
Yes, I will be making follow-up PR to do the final cleanups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the networkingTunnel settings and all traces from the code base.
Fixes: #7426