Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge rancher-desktop-networking v1.2.7 #7452

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

mook-as
Copy link
Contributor

@mook-as mook-as commented Sep 10, 2024

This picks up a change in rancher-desktop-networking that landed in Rancher Desktop 1.15.1 that needed to be merged back into the copy of the code that was merged into the main repo.

Nino-K and others added 3 commits August 9, 2024 11:50
- Added explicit error handling for closing the upstream connection after data is copied.
- Ensured that the upstream connection is closed properly in both the goroutine and the main function.
- Improved logging for connection closure errors.

Signed-off-by: Nino Kodabande <[email protected]>
Ensure proper closure of upstream connection in Pipe function
This picks up a change in rancher-desktop-networking that landed in
Rancher Desktop 1.15.1 that needed to be merged back into the copy of
the code that was merged into the main repo.

Signed-off-by: Mark Yen <[email protected]>
@mook-as mook-as requested a review from Nino-K September 10, 2024 20:57
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois merged commit 16e528f into rancher-sandbox:main Sep 10, 2024
17 checks passed
@mook-as mook-as deleted the networking/re-merge-pr-29 branch September 10, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants