Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unix integration: Symlink docker CLI plugins to bin #7462

Merged

Conversation

mook-as
Copy link
Contributor

@mook-as mook-as commented Sep 11, 2024

To make it easier for rdctl factory-reset, point the docker CLI plugins to the integrations directory (~/.rd/bin/), and in from there into the executables we ship, rather than pointing at the executables directly.

To make it easier for `rdctl factory-reset`, point the docker CLI plugins
to the integrations directory (`~/.rd/bin/`), and in from there into the
executables we ship, rather than pointing at the executables directly.

Signed-off-by: Mark Yen <[email protected]>
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

And BATS passes again without any changes to rdctl.

@jandubois jandubois merged commit 3985d2d into rancher-sandbox:main Sep 11, 2024
17 checks passed
@mook-as mook-as deleted the docker-cli/lima-plugin-dir-rd-bin branch October 3, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants