Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace inet.af → github.com/inetaf #7662

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jandubois
Copy link
Member

@jandubois jandubois commented Oct 18, 2024

The original domain has been lost. gvisor-tap-vsock does the same replacement: https://github.com/containers/gvisor-tap-vsock/blob/2d3bdad/go.mod#L53

Since replacements in go.mod are local and not inherited by projects using the package we need to apply the same replacement ourselves.

The current code only continues to work because the Go module proxy still has it cached under the old name.

The original domain has been lost. gvisor-tap-vsock does the same replacement:
https://github.com/containers/gvisor-tap-vsock/blob/2d3bdad/go.mod#L53

Since replacements in `go.mod` are local and not inherited by projects using
the package we need to apply the same replacement ourselves.

Signed-off-by: Jan Dubois <[email protected]>
@jandubois jandubois requested a review from Nino-K October 18, 2024 20:34
@jandubois jandubois added this to the 1.17 milestone Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant