-
Notifications
You must be signed in to change notification settings - Fork 633
Conversation
Fixes issue #776
Hi @codejamninja ... thanks for the PR... which docker version are you using to test prometheus?? Using local as volume driver and docker 17.03.1-ce, Prometheus is working fine, volumes get correct permissions to nobody/nogroup user...
|
I don't remember |
I just know this fixed it |
It seems issue is not in all docker versions. Yeah, this could fix the issue, but i'm not pretty sure if it's the best way to solve it. Prometheus doesn't recommend to run it as root. I think would be better approach to assure that volume has correct permissions for nobody/nogroup instead run prometheus as root. What do you think?? |
I would agree with you, except not all docker volume drivers give you the capability to do that. |
Also, docker is made to be run as root. It's a sandboxed environment. It's not at all the same things as running your server as root. |
I would agree with you , but software provider doesn't recommend to run it as root. What do you think if we provide one of these solutions??
|
Ah, yes, very nice compromise |
Closing this due to staleness. Feel free to reopen or open a new PR if there's still a relevant change to be made. Thanks! |
Fixes issue #776