Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning about not registered emitters #12130

Closed
cnotv opened this issue Oct 4, 2024 · 0 comments
Closed

Warning about not registered emitters #12130

cnotv opened this issue Oct 4, 2024 · 0 comments
Assignees
@codyrancher
Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/tech-debt Technical debt QA/None
Milestone
v2.10.0

Comments

@cnotv
Copy link
Contributor

cnotv commented Oct 4, 2024 •
edited
Loading

Description

While debugging #12117, a warning highlighted issues regards emitters declaration (and naming?).

No particular issue has been addressed in this case, although it may happen due to the attributes issues.

NOTE: This is a leftover of #11961 which has not been caught by the linter for some reasons.

Kapture.2024-10-04.at.12.35.54.mp4

Markup including the emitters:

Screenshot 2024-10-04 at 12 38 24

Code implementation:
https://github.com/rancher/dashboard/blob/master/shell/mixins/labeled-form-element.ts#L196-L211

Screenshot 2024-10-04 at 12 38 59
@cnotv cnotv added kind/tech-debt Technical debt area/vue3 Bugs and technical debts as outcome to the Vue3 migration labels Oct 4, 2024
@cnotv cnotv added this to the v2.10.0 milestone Oct 4, 2024
@codyrancher codyrancher self-assigned this Oct 10, 2024
codyrancher added a commit to codyrancher/dashboard that referenced this issue Oct 11, 2024
@codyrancher
Fixing more warnings around having the 'emits' component prop
78ad7e6 
Looks like these got missed in the original cleanup. I'm guessing these were missed because they were in mixins so I went through all of the mixins and found a couple more that were missed.

rancher#12130
@codyrancher codyrancher mentioned this issue Oct 11, 2024
Merged
7 tasks
codyrancher added a commit to codyrancher/dashboard that referenced this issue Oct 11, 2024
@codyrancher
Fixing more warnings around having the 'emits' component prop
9fcbadf 
Looks like these got missed in the original cleanup. I'm guessing these were missed because they were in mixins so I went through all of the mixins and found a couple more that were missed.

rancher#12130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyrancher codyrancher

Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/tech-debt Technical debt QA/None
Projects
None yet
Milestone
v2.10.0
Development

No branches or pull requests
2 participants
@cnotv @codyrancher