Fixing more warnings around having the 'emits' component prop #12234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like these got missed in the original cleanup. I'm guessing these were missed because they were in mixins so I went through all of the mixins and found a couple more that were missed. rancher#12130
codyrancher
force-pushed
the
focus-emitters
branch
from
78ad7e6
to
9fcbadf
Compare
|
Are these covering this issue? #12130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Looks like these got missed in the original cleanup. I'm guessing these were missed because they were in mixins so I went through all of the mixins and found a couple more that were missed.
#12130
Areas which could experience regressions
None, no functional changes. It just cleans up some warnings.
Checklist