Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing more warnings around having the 'emits' component prop #12234

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fixing more warnings around having the 'emits' component prop #12234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions shell/mixins/create-edit-view/impl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ export default {

mixins: [ChildHook],

emits: ['done'],

data() {
// Keep label and annotation filters in data so each resource CRUD page can alter individually
return { errors: [] };
Expand Down
2 changes: 2 additions & 0 deletions shell/mixins/labeled-form-element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ interface LabeledFormElement {
export default {
inheritAttrs: false,

emits: ['update:validation', 'on-focus', 'on-blur'],

props: {
mode: {
type: String,
Expand Down
1 change: 1 addition & 0 deletions shell/mixins/vue-select-overrides.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@

export default {
emits: ['option:selecting', 'option:created', 'option:selected'],
methods: {
mappedKeys(map, vm) {
// Defaults found at - https://github.com/sagalbot/vue-select/blob/master/src/components/Select.vue#L947
Expand Down
Loading