Fix AKS count validation message #11907
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11842 - see comments in the backport issue
Occurred changes and/or fixed issues
This PR updates AKS node pool count validation. Based off what I see in the Azure portal, AKS pools may have a count of 0 if the pool mode is 'User' - I wish I understood where I got the idea that this was actually dependent on the enableAutoScaling property last week but life is full of mysteries I guess.
Technical notes summary
I moved the validator function into a utility to make it easier to add some unit tests.
Areas or cases that should be tested
Verify that node pool count is validated to be >=1 in system pools and >=0 in user pools (ie when count is invalid an error message is shown and create button greyed out)
Screenshot/Video
Screen.Recording.2024-09-12.at.1.28.35.PM.mov
Checklist