Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AKS count validation message #11907

Conversation

mantis-toboggan-md
Copy link
Member

Summary

Fixes #11842 - see comments in the backport issue

Occurred changes and/or fixed issues

This PR updates AKS node pool count validation. Based off what I see in the Azure portal, AKS pools may have a count of 0 if the pool mode is 'User' - I wish I understood where I got the idea that this was actually dependent on the enableAutoScaling property last week but life is full of mysteries I guess.

Technical notes summary

I moved the validator function into a utility to make it easier to add some unit tests.

Areas or cases that should be tested

Verify that node pool count is validated to be >=1 in system pools and >=0 in user pools (ie when count is invalid an error message is shown and create button greyed out)

Screenshot/Video

Screen.Recording.2024-09-12.at.1.28.35.PM.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Member

@eva-vashkevich eva-vashkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mantis-toboggan-md mantis-toboggan-md merged commit c6ad2e6 into rancher:master Sep 13, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AKS: Allow 0 NodeCount for User mode pools
2 participants