Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LabeledSelect: Filter $attrs applied to v-select #12062

Merged

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Sep 27, 2024

Summary

This filters the attrs that have already been applied to the wrapper div of LabeledSelect so that they don't get applied to the inner v-select.

This duplicate application was causing additional classes like mr-10 & in-input to be applied to both the wrapper div and v-select, causing visual regressions when custom classes were applied.

Fixes #11954

Occurred changes and/or fixed issues

  • Filter attrs to be applied to v-select in LabeledSelect.vue

Technical notes summary

Areas or cases that should be tested

  • This changes all instances of LabeledSelect, so we will need to assert that other usages haven't regressed

Areas which could experience regressions

  • All instances of LabeledSelect

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rak-phillip rak-phillip added this to the v2.10.0 milestone Sep 27, 2024
@rak-phillip rak-phillip self-assigned this Sep 27, 2024
@rak-phillip rak-phillip changed the title LabeledSelect: Filter $attrs applied to wrapper div LabeledSelect: Filter $attrs applied to v-select Sep 28, 2024
Copy link
Member

@momesgin momesgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did check some of the use cases after this change and didn't find anything being broken/altered. LGTM

@rak-phillip rak-phillip merged commit 211a051 into rancher:master Oct 2, 2024
40 checks passed
@rak-phillip rak-phillip deleted the bugfix/11954-service-account-sizing branch October 2, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workload: Container: Large sizing regression for Service Account Name
2 participants