LabeledSelect: Filter $attrs
applied to v-select
#12062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This filters the attrs that have already been applied to the wrapper
div
ofLabeledSelect
so that they don't get applied to the innerv-select
.This duplicate application was causing additional classes like
mr-10
&in-input
to be applied to both the wrapperdiv
andv-select
, causing visual regressions when custom classes were applied.Fixes #11954
Occurred changes and/or fixed issues
v-select
inLabeledSelect.vue
Technical notes summary
Areas or cases that should be tested
LabeledSelect
, so we will need to assert that other usages haven't regressedAreas which could experience regressions
LabeledSelect
Checklist