Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.10] Improve cloud cred e2e tests #12209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[2.10] Improve cloud cred e2e tests #12209

wants to merge 1 commit into from

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Oct 10, 2024 •
edited
Loading

Summary

Improve cloud cred e2e tests

Occurred changes and/or fixed issues

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox
Improve cloud cred e2e tests
01f3d0b 
- don't nuke all cloud creds before tests starts, instead tidy up cloud creds created during tests at end
- use safer method of creating cloud creds and running dependent tests
  - instead of looping over but running tests at end of each chain create them then run test
- most important one, make creds THEN navigate to the page to ensure all creds are correctly in store
  - there's no socket updates for these, so we have to be sure they can be returned before we load the dashboard
@richard-cox richard-cox added this to the v2.10.0 milestone Oct 10, 2024
@richard-cox richard-cox self-assigned this Oct 10, 2024
@richard-cox richard-cox mentioned this pull request Oct 10, 2024
Merged
7 tasks
@richard-cox richard-cox changed the title Improve cloud cred e2e tests [2.10] Improve cloud cred e2e tests Oct 10, 2024
@richard-cox richard-cox marked this pull request as ready for review October 10, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eva-vashkevich eva-vashkevich Awaiting requested review from eva-vashkevich

@aalves08 aalves08 Awaiting requested review from aalves08

At least 1 approving review is required to merge this pull request.

Assignees

@richard-cox richard-cox

Labels
None yet
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@richard-cox