Set creator principal id annotation when creating projects and v3 clusters #12233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyrancher
reviewed
Oct 11, 2024
| @@ -103,6 +103,9 @@ export default { | |||
| this.value.metadata['namespace'] = this.$store.getters['currentCluster'].id; | |||
| this.value['spec'] = this.value.spec || {}; | |||
| this.value.spec['containerDefaultResourceLimit'] = this.value.spec.containerDefaultResourceLimit || {}; | |||
| if (!this.$store.getters['auth/principalId'].includes('local://')) { | |||
There was a problem hiding this comment.
it might make sense to add a utility or a getter to check isPrincipalIdLocal.
codyrancher
previously approved these changes
Oct 11, 2024
yonasberhe23
previously approved these changes
Oct 11, 2024
mantis-toboggan-md
dismissed stale reviews from yonasberhe23 and codyrancher
via
c69b0b7
mantis-toboggan-md
force-pushed
the
principal-ids
branch
from
090884e to
c69b0b7
Compare
yonasberhe23
approved these changes
Oct 15, 2024
nwmac
pushed a commit
to nwmac/dashboard
that referenced
this pull request
Oct 24, 2024
…sters (rancher#12233) * set principal id annotation when creating projects * set creator principal id when creating kontainer and machine driver clusters * correct kontainer provisioning principal id annotation * add test for project creation * fix projects afterEach hook
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11852
Occurred changes and/or fixed issues
This PR adds an annotation to projects and v3 clusters when using third-party auth. There is a corresponding ember PR which covers rke1 clusters and importing aks/eks/gke clusters
Areas or cases that should be tested
Using local auth, verify that no principal id annotation is set when creating projects and aks/eks/gke clusters. Using third party auth, verify that the
field.cattle.io/creator-principal-nameis set when creating projects and aks/eks/gke clusters.Checklist