Fix a problem with deleting role templates from the respective detail pages #12270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were attempting to navigate back to a non-existent page when deleting role templates from their corresponding detail pages. This caused the Prompt Remove dialog to show an error button and not close. rancher#12217
codyrancher
changed the title
codyrancher
commented
Oct 15, 2024
Comment on lines
-108
to
-109
| if (this.toRemove[0].doneLocationRemove) { | ||
| return this.toRemove[0].doneLocationRemove; |
There was a problem hiding this comment.
doneLocationRemove is no longer used in our codebase.
It was originally added to support Epinio 917ce2e
We do need to respect doneOverride here just like we do in other locations so I decided to swap the two.
rak-phillip
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just as a note, this issue isn't new. It's at the very least present in 2.9.
We were attempting to navigate back to a non-existent page when deleting role templates from the corresponding detail pages. This caused the Prompt Remove dialog to show an error button and not close.
#12217
Areas or cases that should be tested
This delete problem was present in all of the role template categories (global, cluster, project/namespaces). We should verify each of these.
Areas which could experience regressions
Possibly the way we remove other resources which override the done location. I've verified against namespaces and deployment workloads.
Checklist