Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gke provisioning form stale data #12279

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

mantis-toboggan-md
Copy link
Member

Summary

Fixes #11864

This PR updates the gke provisioning form to ensure that any default configuration applied when creating clusters copies the defaults defined in the component instead of modifying the default configuration object, so that when the component is reused, the default configuration has not been changed.

Areas or cases that should be tested

  1. Create a new GKE cluster and enable private cluster, private endpoint, and master authorized network (all under the advanced section of the networking tab)
  2. After saving, go to create another GKE cluster: verify that the advanced networking section has been reset to default values (all 3 checkboxes unchecked)

Areas which could experience regressions

none

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Member

@eva-vashkevich eva-vashkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mantis-toboggan-md mantis-toboggan-md merged commit aa015ed into rancher:master Oct 16, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.9] [GKE] Hosted Provider create form retain old values
2 participants